Conversation
… lodash Also fixes Windows build scripts by using cross-env.
MrCodeBS
force-pushed
the
fix-string-utils-and-windows-build
branch
from
September 15, 2026 08:38
80d7a50 to
3b23a3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses two technical debt/bug issues found in the codebase: 1) It fixes a bug in endsWithSingleSpace where strings consisting only of spaces wouldn't be checked properly due to the \S token. 2) It replaces custom string utility methods in src/util/string.js with lodash equivalents, as requested by TODO comments. 3) Modifies package scripts to use cross-env so it can be built and run on Windows machines.