support long else...if blocks? - #897
Open
spaghetti-squash wants to merge 9 commits into
Open
Conversation
spaghetti-squash
enabled auto-merge
September 6, 2026 19:20
Ignose
approved these changes
Sep 7, 2026
Ignose
left a comment
Contributor
There was a problem hiding this comment.
I'm not sure where size limits for macros are housed (maybe Libram lets the user put this particular gun to this foot) but otherwise this looks good.
Contributor
Author
Libram doesn't track size limits, macros are remarkably stateless. Like, all they contain is an array of bare strings for their steps. We could adjust the Type of the ElseTrain to be |
use an overload signature for if_
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This essentially lets us continue to honor the contract of
if_as it previously existed and as it existed in the firstelsework. But we don't need to honor the latter, because it hasn't been released.I don't love that the frontmost elements don't need to be an object but subsequent entries do. Maybe it makes sense to keep
if_as it once was, and doifElsethat accepts just anElseTrainargument?