Fix XLSX save after deleting formatted columns - #516
Closed
freddy-bio wants to merge 1 commit into
Closed
freddy-bio wants to merge 1 commit into
freddy-bio wants to merge 1 commit into
Conversation
|
@freddy-bio is attempting to deploy a commit to the JeremyHe's projects Team on Vercel. A member of the Team first needs to authorize it. |
Member
|
@freddy-bio Thanks for your contribution. May I ask why this PR is closed? |
Author
|
hey, thanks to you. I apologise, Codex did this automatically, and I didn't test it as didn't have time, so I proceeded to close it. Sorry about this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleting a column with a custom width leaves its stable column ID in
ColInfoManager. XLSX save then callsfetch_col_idx(...).unwrap()for that deleted ID and panics withColIndexUnavailable, so an otherwise valid workbook cannot be exported.Remove the deleted column's formatting when
DeleteColsruns, and skip orphaned column metadata in the XLSX writer so already-affected in-memory workbooks can also save. A regression test covers save/reload after deletion and saving after undo/redo.Validation:
cargo test -p logisheets_controller --lib(473 passed);cargo fmt --all -- --check.