Repository navigation
select: Open the list below the trigger on Windows and Linux - #1435
Merged
Merged
Conversation
Every desktop opened a Select's list over the trigger with the chosen row laid on it. That is how macOS pop-up buttons behave; the drop-down lists of Windows and Linux open below the trigger instead. The list now covers the trigger on macOS only. Windows, Linux and browsers open it below the trigger, as a Combobox already does, with placement, align, offset and margin applying as they do when nothing is chosen. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On every desktop,
Selectopened its list over the trigger with the chosenrow laid on it. That is how macOS pop-up buttons behave, but the drop-down
lists of Windows and Linux (WinUI's ComboBox, GTK's DropDown) open below the
trigger, so a select on those platforms did not behave as their own
controls do.
Now the list covers the trigger on macOS only. On Windows, Linux and in
browsers (where the runtime reports the web, not the OS underneath) it
opens below the trigger, as a
Comboboxalready does;placement,align,offsetandmarginapply there as they do with nothing chosen.Terminals keep opening it below the trigger. Phones and tablets keep their
sheet.
Public API
No new API. Behavior change: on Windows, Linux and the web in the desktop
idiom, a
Select's list with a chosen item opens below the trigger insteadof over it.
Validation
nsh-basetests: newselect::on_macos_the_chosen_item_opens_over_the_trigger(the popup starts above the trigger so the chosen row lies on it; below it
with nothing chosen) and
select::on_windows_and_linux_the_list_drops_below_the_trigger(Windows,Linux and the web: below the trigger, at its start, as wide, with an item
chosen). The
selectsuite passes.cargo +nightly fmt --all,cargo clippy -p nsh-base --all-targets.change and was not run on a Mac here.
🤖 Generated with Claude Code