feat(trade): add attached order (take-profit/stop-loss) support#549
Draft
sunli829 wants to merge 9 commits into
Draft
feat(trade): add attached order (take-profit/stop-loss) support#549sunli829 wants to merge 9 commits into
sunli829 wants to merge 9 commits into
Conversation
sunli829
marked this pull request as draft
June 22, 2026 06:58
sunli829
marked this pull request as ready for review
July 21, 2026 01:22
sunli829
force-pushed
the
feat/attached-orders
branch
from
July 21, 2026 01:50
081c306 to
eac5f47
Compare
sunli829
marked this pull request as draft
July 21, 2026 01:51
4 tasks
Add attached order API support across all language SDKs based on developers PR #1092. New types: - AttachedOrderType enum (ProfitTaker / StopLoss / Bracket) - AttachedOrderDetail response struct - SubmitAttachedParams / ReplaceAttachedParams request builders - GetOrderDetailOptions (with is_attached flag) API changes (non-breaking): - Order / OrderDetail: new attached_orders field - SubmitOrderOptions: new attached_params builder - ReplaceOrderOptions: new attached_params builder - GetTodayOrdersOptions: new is_attached() flag - order_detail: accepts impl Into<GetOrderDetailOptions> - New order_detail_attached method (Rust/Python/Node.js/Java/C/C++)
Bugs fixed: - AttachedOrderType serialized as "Bracket" instead of "BRACKET" — switched from #[derive(Serialize)] to impl_serde_for_enum_string! to use strum Display - SubmitOrderOptions.expire_date serialized as null when absent — added skip_serializing_if = "Option::is_none" - AttachedOrderDetail.attached_type_display was i32, now AttachedOrderType - AttachedOrderDetail.trigger_status was i32, now Option<TriggerStatus> - AttachedOrderDetail.tag was i32, now OrderTag - AttachedOrderDetail.executed_price was Decimal, now Option<Decimal> - OrderDetail.charge_detail was non-optional, now Option<OrderChargeDetail> (C SDK: added has_charge_detail bool flag) - Java SdkNative.tradeContextOrderDetailAttached missing public modifier Add AttachedOrderType::Unknown variant across all language bindings. Add submit_order_with_attached examples for all languages. Update CLAUDE.md: python/pyproject.toml uses dynamic = ["version"].
…nd GetOrderDetailOptions is_attached=true indicates that the provided order_id is an attached sub-order ID, not a regular order ID. It does not filter results to show only attached orders.
is_attached=true only takes effect when combined with order_id. It tells the server to treat order_id as an attached sub-order ID for lookup. Without order_id it has no effect and does NOT filter results to show only attached orders.
…rent Based on actual API testing: today_orders(order_id=attached_id, is_attached=True) returns the attached sub-order as an Order entry with its own order_id, side, order_type etc — not the parent order.
Rebasing feat/attached-orders onto main required merging attached-order changes with the US market APIs / client_request_id features; the naive git merge left nodejs/index.d.ts with duplicate US-market method declarations (no conflict markers, just misaligned content). Rebuilding with napi and rustfmt brings the generated files back in sync with the Rust source.
The withdraw endpoint gained an optional is_attached flag (per developers PR #1092) so a take-profit/stop-loss sub-order can be cancelled by its own order ID. Wired non-breakingly per language: Rust CancelOrderOptions (impl Into<T>, backward-compatible via From<&str>/From<String>), Python is_attached kwarg, Node.js optional isAttached param, C++ defaulted parameter, Java cancelOrder overload, and a new C lb_trade_context_cancel_order_attached symbol.
sunli829
force-pushed
the
feat/attached-orders
branch
from
July 22, 2026 09:13
90a9684 to
2449171
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added
AttachedOrderType(ProfitTaker / StopLoss / Bracket),AttachedOrderDetail,SubmitAttachedParams,ReplaceAttachedParamsSubmitOrderOptions/ReplaceOrderOptions: newattached_paramsfieldOrder/OrderDetail: newattached_ordersfieldorder_detail_attached(order_id)method — queries detail for an attached sub-order by its own IDGetTodayOrdersOptions: newis_attachedflag — when combined withorder_id, tells the server to treatorder_idas an attached sub-order ID; returns that sub-order as anOrderentry (not the parent)Breaking changes
OrderDetail.charge_detailis nowOption<OrderChargeDetail>— attached orders returnnullfor this field; callers must handle the absent caselb_order_detail_tgains a newhas_charge_detail: boolfield beforecharge_detail; ABI changed, recompile requiredTest plan
openapi.longbridge.xyzis_attachedsemantics verified against live API🤖 Generated with Claude Code