Stop cost accrual for already-deleted RunPod workers (0.13.1) - #84
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The production GPU cost smoke test found that a worker can delete its own pod before marking its database record terminated. RunPod then rejects the manager’s repeat termination request with
Unauthorized, leaving costs accruing indefinitely.Confirm pod absence with a successful provider lookup after a failed termination request. A missing pod now closes the worker accounting interval; an existing pod or failed lookup keeps it open for retry. Add regression tests for all three outcomes and prepare 0.13.1. No additional schema migration is required.