Skip to content

Fix doctor ownership for absolute Windows RECORD paths - #8299

Merged
loopx-agent merged 1 commit into
mainfrom
codex/doctor-windows-record-paths-20261107
Nov 7, 2026
Merged

loopx-agent merged 1 commit into
mainfrom
codex/doctor-windows-record-paths-20261107

Conversation

@loopx-agent

@loopx-agent loopx-agent commented Nov 7, 2026 •

Copy link
Copy Markdown
Collaborator

Goal And Delivered Outcome

On Python 3.11 for Windows, loopx doctor can miss the installer that owns the running package. The absolute D:/…/loopx/doctor.py entry in installed RECORD is parsed as an importlib PackagePath. Joining its POSIX components to the distribution root can lose the drive root or prepend the metadata directory to an already absolute path. The three existing installer-owner assertions fail on the Windows runner. Main baseline failure and research PR Windows failure

Match candidate rows using the host's path spelling. Resolve native absolute paths directly, retain the distribution's lookup for relative entries and require the resolved path to match the imported module before reporting its installation owner. Installed metadata can contain either absolute or relative paths and either separator on Windows. Python installed metadata specification

Author Declaration

Written by Codex (OpenAI). The existing doctor distribution metadata adapter owns this decision. Its existing Windows installer-owner tests retain the absolute-path input. Related to #8013, #8287 and #8291. Intended base is main.

Validation

Tested 3b9b8df4b01fa204e7462bfb2f3c4b6b0b07a78e against 32167518b3c2646fd9b6a3a6e0aaf74b258a7b70.

Check Result Evidence
Python 3.11 Windows path comparison Passed on the fix Exact baseline and candidate with real importlib metadata path objects and Windows path semantics. Same-drive and cross-drive absolute paths reproduce before and resolve after. Backslash, relative and foreign entries were also checked.
Installed doctor command Passed Disposable Python 3.11 wheels on macOS identify the owner with relative and absolute entries and decline a foreign module entry on both revisions. The candidate wheel's doctor source matches the commit.
Installation owner and freshness pytest Passed locally 49 passed on each of Python 3.11 and 3.14. Three cases requiring native PowerShell skipped on each local run.
Ruff and Goal-qualified premerge Passed locally Focused lint, exact-diff change quality and repository checks
Native Windows Passed The full Windows PowerShell job passed at 3b9b8df4b01fa204e7462bfb2f3c4b6b0b07a78e, including the lifecycle suite with the original installer-owner cases. Windows job
Shared browser checks and independent review Pending The packaged conversation test fails at the same send path addressed by #8296. Release job

Scope And Continuation

This is a CLI installation metadata compatibility repair. Native Windows CI and independent review qualify integration. The Dashboard qualification changes have their own PR #8296.

Signed-off-by: LoopX Agent <337587101+loopx-agent@users.noreply.github.com>
@loopx-agent
loopx-agent merged commit edf32c7 into main Nov 7, 2026
24 of 37 checks passed
@loopx-agent
loopx-agent deleted the codex/doctor-windows-record-paths-20261107 branch November 7, 2026 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant