Repository navigation
DM-56811: Fit glint trails using perpendicular distances - #484
Merged
Merged
Conversation
isullivan
force-pushed
the
tickets/DM-56811
branch
from
October 26, 2026 21:00
f381b62 to
df17139
Compare
bsmartradio
approved these changes
Oct 26, 2026
bsmartradio
left a comment
bsmartradio
left a comment
Contributor
There was a problem hiding this comment.
One minor comment about the default and one other one about a logging message.
| doc="Maximum perpendicular distance of a source from the line fit to its trail (pixels).", | ||
| dtype=float, | ||
| default=15.0, | ||
| default=2.0, |
Contributor
There was a problem hiding this comment.
Do we have any comments where we explain the default? Not necessary but might be useful for future reading.
RANSACRegressor regressed y on x, so it could not fit vertical trails and fit steep ones poorly. Its squared_error loss also compared the squared vertical residual to threshold, making the old default of 15 a cut of about 3.9 pixels. threshold is now a perpendicular distance in pixels, with a default of 2 for a tighter fit.
A trail of exactly min_points sources was never searched, because each of its sources has only min_points - 1 matches.
isullivan
force-pushed
the
tickets/DM-56811
branch
from
October 26, 2026 23:16
df17139 to
36c9f98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the slope would diverge for nearly vertical lines. The change in the default threshold is partly due to taking the square root of the previous value for comparison, and partly tightening the fit to allow fewer false detections.