Repository navigation
Upgrade to wish v2 (charm.land/wish/v2) - #13
Closed
lukasschwab wants to merge 1 commit into
Closed
lukasschwab wants to merge 1 commit into
lukasschwab wants to merge 1 commit into
Conversation
Migrate all Charmbracelet dependencies to their v2 charm.land module paths: - charm.land/wish/v2 v2.0.1 (from github.com/charmbracelet/wish v1.4.7) - charm.land/bubbletea/v2 v2.0.6 - charm.land/lipgloss/v2 v2.0.3 - charm.land/bubbles/v2 v2.1.0 - charm.land/log/v2 v2.0.0 Key changes for Bubble Tea v2 compatibility: - View() returns tea.View instead of string; use v.AltScreen for alt screen - tea.KeyMsg replaced with tea.KeyPressMsg - lipgloss.NewStyle() no longer takes a renderer (auto-detected) - Remove bubbletea.MakeRenderer(); use bubbletea.MakeOptions(s) for SSH I/O - textinput.PromptStyle replaced with textinput.SetStyles() Resolves dependabot alert #4: wish SCP path traversal (GHSA affecting github.com/charmbracelet/wish <= v1.4.7). Co-authored-by: Shelley <shelley@exe.dev>
Owner
Author
|
Closing — unnecessary. Vulnerable middleware is unused. No independent reason to make these version upgrades. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates all Charmbracelet dependencies to their v2
charm.landmodule paths, resolving dependabot alert #4 (SCP path traversal ingithub.com/charmbracelet/wish <= v1.4.7).Changes
github.com/charmbracelet/wishv1.4.7)Migration details
Following the wish v2 upgrade guide:
View()returnstea.Viewinstead ofstring; alt screen set viav.AltScreen = truetea.KeyMsg→tea.KeyPressMsglipgloss.NewStyle()no longer takes a renderer (color profile auto-detected in Bubble Tea v2)bubbletea.MakeRenderer(s); usingbubbletea.MakeOptions(s)for SSH I/O setuptextinput.PromptStylefield replaced withtextinput.SetStyles()Builds and tests pass on Go 1.25.9.