Repository navigation
refactor: fix Rust CI deps and document unsafe blocks - #1
Merged
Merged
Conversation
Ubuntu jobs failed in libspa-sys (no libpipewire-0.3) and macOS jobs failed building audiopus_sys through CMake because opus was not installed.
Add workspace clippy lints (undocumented_unsafe_blocks, missing_safety_doc), SAFETY comments for the Linux unsafe blocks, and abort the libei capture task in Drop instead of panicking while it still holds a raw pointer.
Convert extern blocks to unsafe extern, wrap macOS set_var calls in unsafe, document the test env mutation, apply let-chain clippy suggestions, and run the wall-clock audio loopback test only on Linux.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
libpipewire-0.3-dev,libopus-dev,libclang-dev,libasound2-dev; macOS getsopus,pkgconf; Windows jobs build with MSYS2 clang64 +gnullvm(same recipe asrelease-windows.yml) instead ofgvsbuild.unsafe externblocks,unsafearoundenv::set_var,unsafe fnbodies wrapped inunsafe {}, let-chain clippy suggestions.clippy::all,undocumented_unsafe_blocks,missing_safety_doc, with// SAFETY:comments for everyunsafeblock on Linux, macOS and Windows.LibeiInputCapture::dropaborts the capture task and logs instead of panicking.audio_keeps_flowing_through_the_whole_pipelinetest is#[ignore]d outside Linux (macOS/Windows runners cannot hold 20 ms timers).nix/README.md.CI status
All 17 jobs pass (build/check/clippy/test on Ubuntu, macOS arm64, macOS Intel, Windows, plus Formatting).
Caveats
unsafe impl Send for MacOSEmulationrests on the app creating and driving it inside aspawn_localtask on a current-thread runtime; read from code, not tested.