Skip to content

Finish lifecycle and behavior-test cleanup - #13

Merged
lumirth merged 3 commits into
mainfrom
codex/finish-giscusflare-cleanup
Oct 14, 2026
Merged

lumirth merged 3 commits into
mainfrom
codex/finish-giscusflare-cleanup

Conversation

@lumirth

@lumirth lumirth commented Oct 14, 2026 •

Copy link
Copy Markdown
Owner

Summary

Consolidate content, directive and host-initialization lifetimes. Remove verification of isolated helpers and implementation shape, and strengthen existing application journeys around supported outcomes.

- duplicated browser restoration and resource ownership
+ shared initialization and owned content/directive lifetimes
- renderer/helper suites and a private ranking integration harness
+ production Worker and native/iframe journeys with independent readback
- committed runtime declarations and duplicate archived CSS inputs
+ generated runtime types and explicit pinned CSS projection

Retain vendor regeneration provenance and separate package compile/artifact validation as check:package. Apply the retroactive test policy through deletion and consolidation. The simulated provider now executes field selections against the pinned official GitHub schema; browser engines use independent service/provider environments with deployment limits intact.

Evidence

  • Before: the gate included direct renderer lifecycle checks, a ranking harness that inserted sessions and called internal engines, and generated-output/query-shape assertions. Some browser recovery checks fabricated application error responses, and immediate publication patches were described as readback.
    After: the rejected suites and unused machinery are deleted. Existing journeys now demonstrate ranked pagination and score changes, comment/reply reading after document reload, real session revocation, safe rich content, and canonical custom edits during delayed/failed interpretation. Edits receive separate anonymous provider readback; visible Retry preserves usable mounted controls and newer output survives late older work. Transport failures replace fabricated application responses.
  • npm run check:release passed locally; the final browser sequencing change also passed both engines. The hosted release gate passed on final commit f48bffa: generated types, browser/Worker/example typechecks, builds, production workerd workflows, Chromium and WebKit native/iframe/custom journeys, and extracted-package consumer compilation.
  • Deployment dry run passed for production cleanup commit 3048766, including the changed build hook and nested type generation without recursion. Follow-up commits e470112 and f48bffa change verification fixtures, journeys and documentation.
  • git diff --check passed. Parallel source/policy review found no introduced production defect. TESTING.md maps supported outcomes to independent observations and records the remaining boundaries: simulated GitHub does not qualify real App permissions, production capacity, physical devices or every custom producer/resource failure.

Merge Danger

Door: two-way

No storage migration. Deleted generated declarations and vendor reference inputs are reproducible from documented configuration and pinned history.

Blast Radius: consumers

Content preparation, presentation lifetimes and session restoration affect default and custom native/iframe consumers. Application journeys exercise those paths. Caching and provider diagnostics follow as separate work.

@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@lumirth
lumirth merged commit 2991ff0 into main Oct 14, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant