Repository navigation
Finish lifecycle and behavior-test cleanup - #13
Merged
Merged
Conversation
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Consolidate content, directive and host-initialization lifetimes. Remove verification of isolated helpers and implementation shape, and strengthen existing application journeys around supported outcomes.
Retain vendor regeneration provenance and separate package compile/artifact validation as
check:package. Apply the retroactive test policy through deletion and consolidation. The simulated provider now executes field selections against the pinned official GitHub schema; browser engines use independent service/provider environments with deployment limits intact.Evidence
After: the rejected suites and unused machinery are deleted. Existing journeys now demonstrate ranked pagination and score changes, comment/reply reading after document reload, real session revocation, safe rich content, and canonical custom edits during delayed/failed interpretation. Edits receive separate anonymous provider readback; visible Retry preserves usable mounted controls and newer output survives late older work. Transport failures replace fabricated application responses.
npm run check:releasepassed locally; the final browser sequencing change also passed both engines. The hosted release gate passed on final commitf48bffa: generated types, browser/Worker/example typechecks, builds, production workerd workflows, Chromium and WebKit native/iframe/custom journeys, and extracted-package consumer compilation.3048766, including the changed build hook and nested type generation without recursion. Follow-up commitse470112andf48bffachange verification fixtures, journeys and documentation.git diff --checkpassed. Parallel source/policy review found no introduced production defect. TESTING.md maps supported outcomes to independent observations and records the remaining boundaries: simulated GitHub does not qualify real App permissions, production capacity, physical devices or every custom producer/resource failure.Merge Danger
Door: two-way
No storage migration. Deleted generated declarations and vendor reference inputs are reproducible from documented configuration and pinned history.
Blast Radius: consumers
Content preparation, presentation lifetimes and session restoration affect default and custom native/iframe consumers. Application journeys exercise those paths. Caching and provider diagnostics follow as separate work.