Repository navigation
Redact query strings from Workers logs - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Workers invocation logs include request URLs. Redact query strings so OAuth callback codes and state stay out of persistent logs while operation, status, latency and application request IDs remain available.
observability enabled: true + redact_query_string: trueEvidence
redact_query_string: falseby default.After: the production API setting was updated and read back as
true; source configs now preserve it on future deployments.Merge Danger
Door: two-way
Blast Radius: logs
Request query strings are omitted from platform logs. Existing bindings, secrets, namespace, code and structured application diagnostics are preserved.