Repository navigation
Add diode status and guard blocked receivers - #10
Merged
Merged
Conversation
lumirth
marked this pull request as ready for review
October 14, 2026 18:11
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add diode status in the screen margin during connection: × for missing, arrows for reversal, and solid for connected. Connected confirmation clears when the exchange ends. A diagnosed fault stays visible on the relevant connection screen until correction or leaving; an inconclusive follow-up cannot erase it. Communication errors never create diode warnings.
Detect presence with bounded capacitance checks and reversal with a weak-current voltage sweep, including a dark forward-junction test. Reject a blocked or missing input before strong GPIO precharge. Checks run for the attempt, with at most three follow-ups after rejection; the sensor is released afterward.
Give orientation labels, panel rotation and icon placement one shared definition. Left side down places the icon at top left; right side down places it at bottom right. Both have four pixels of padding. Existing physical rotation choices are preserved. The original Pokéwalker connection flow and result screens remain unchanged.
Validation: production build, static checks, host tests and all 20 production simulator scenarios, including dark reversal, strong light, shorts, both corners, fault persistence, quiet no-reply failures, cleanup after hardware/software timeouts, save recovery, and peer transfers/play. Physical checks detected the inserted diode and an unpopulated GPIO6 control on four checks each, taking about 129 ms. A physical weak-bias sweep verified the inserted diode's response; physical reversed and empty-GPIO5 sweeps were not captured. Electrical evidence.