Skip to content

Choose and list the parity diagram set - #214

Merged
HassanAkbar merged 1 commit into
mainfrom
lane/81-04-choose-and-list-the-parity-diagram-set
Nov 16, 2026
Merged

HassanAkbar merged 1 commit into
mainfrom
lane/81-04-choose-and-list-the-parity-diagram-set

Conversation

@HassanAkbar

Copy link
Copy Markdown
Member

Choose and list the parity diagram set

Part of #54: EA parity: generated SVGs must be fully identical to EA's own SVG export (fonts, connectors, geometry)

Problem

There is no fixed list of diagrams to export from EA; a maintainer needs exact diagram GUIDs that cover the #51/#52/#53 cases.

Fix

  • From examples/qea/20251010_current_plateau_v5.1.qea, choose about 10 diagrams: class diagrams, ones with connectors at stored edges, notes/labels, non-default fonts, and any that hit the nil-coordinate path
  • Write spec/fixtures/parity/manifest.yml (model path, diagram GUID/EAID, name, which defect it covers) and a README.md with EA export steps (File > Save diagram as SVG, filename .svg)
  • Add a small spec that checks every manifest GUID exists in the model

Done when

  • spec/ea/svg/parity/manifest_spec.rb passes: each listed diagram is found in the QEA document
  • the README states the exact export procedure and target directory

check.rb:
Warning! PATH is not properly set up, /Users/umerhassan/.rvm/gems/ruby-3.4.8/bin is not at first place.
Usually this is caused by shell initialization files. Search for PATH=... entries.
You can also re-add RVM to your profile by running: rvm get stable --auto-dotfiles
To fix it temporarily in this shell session run: rvm use ruby-3.4.8
To ignore this error add rvm_silence_path_mismatch_check_flag=1 to your ~/.rvmrc file.
specs: PASS 1 examples, 0 pending (1 files, 91s)
rubocop: PASS (1 files)

@HassanAkbar

Copy link
Copy Markdown
Member Author

@ribose-cla agree icla

@ribose-cla

ribose-cla Bot commented Nov 16, 2026

Copy link
Copy Markdown

@HassanAkbar recorded — this pull request is contributed under the Individual CLA v1.0. The check re-ran and reflects it.

@HassanAkbar
HassanAkbar merged commit 9d5e30f into main Nov 16, 2026
13 checks passed
@ribose-cla

ribose-cla Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

CLA attribution for this merged contribution

  • @HassanAkbar — this work is submitted under an existing Ribose agreement; the CLA process does not apply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant