Skip to content

Point stale parity specs at committed fixtures - #217

Open
HassanAkbar wants to merge 1 commit into
mainfrom
lane/81-08-point-stale-parity-specs-at-committed-fi
Open

HassanAkbar wants to merge 1 commit into
mainfrom
lane/81-08-point-stale-parity-specs-at-committed-fi

Conversation

@HassanAkbar

Copy link
Copy Markdown
Member

Point stale parity specs at committed fixtures

Part of #54: EA parity: generated SVGs must be fully identical to EA's own SVG export (fonts, connectors, geometry)

Problem

visual_regression_spec and sample_exports_regression_spec hardcode /Users/mulgogi and ~/src paths and always skip in CI, which hides real coverage.

Fix

  • Remove the hardcoded user paths; keep the ENV overrides as optional extras, and drop examples that the c7 gate now covers

Done when

  • neither spec references a /Users/ path
  • rake spec green

check.rb:
Warning! PATH is not properly set up, /Users/umerhassan/.rvm/gems/ruby-3.4.8/bin is not at first place.
Usually this is caused by shell initialization files. Search for PATH=... entries.
You can also re-add RVM to your profile by running: rvm get stable --auto-dotfiles
To fix it temporarily in this shell session run: rvm use ruby-3.4.8
To ignore this error add rvm_silence_path_mismatch_check_flag=1 to your ~/.rvmrc file.
specs: PASS 4 examples, 4 pending (2 files, 0s)
rubocop: PASS (2 files)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant