Repository navigation
Sonny tests: hold the mux worker until the kept places are read - #684
Merged
Merged
Conversation
`a_view_that_opens_reads_where_the_windows_sit_now` sent a job that closes and opens windows, then read the places kept from before it. The worker thread could run that job and refresh the kept places first, so the test failed now and then (seen on #675 and #680). A job ahead of it now holds the worker until the read is done, as the naming test beside it does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013jkdGG873rfqV9CdHz7KrE
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mux::tests::a_view_that_opens_reads_where_the_windows_sit_nowraces its own worker thread. The test sends a job that closesshop.aand opensshop.c, then reads the places kept from before that job (Worker::places). The worker can run the job and refresh the kept places before the test thread takes the lock. When it does, the test sees the new layout and fails withleft: (None, Some(2)),right: (Some(1), None). That has failed CI three times today: twice on #680 and once on #675.Now a job sent ahead of the close holds the worker on a channel until the kept read is done, as
a_worker_runs_jobs_in_order_and_skips_a_naming_that_another_followsbeside it already does. The code under test is unchanged.Test plan
cargo test -p sonny a_view_that_opens_reads, run in a loop locally.No FEATURES row: this is a test-only change.
🤖 Generated with Claude Code
https://claude.ai/code/session_013jkdGG873rfqV9CdHz7KrE