Repository navigation
Conversation
Every save and removal answers with index_bytes and limit; from 90% full it adds merge_candidates (pairs alike by shared words, the longest lines, facts unread 30 days), found without a model, and memory_full names the same facts. A new index line is at most 204 bytes, an eightieth of the index, so an index holds at least eighty facts; a fact whose line was already longer may be saved with a line no longer than it had. The memory tool, the memory and cleanup skills and docs say so. The index budget stays 16 KiB: both indexes go whole into every agent's instructions, which are capped at 60 KiB, so a larger budget would make agents fail to start. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013jkdGFAkmSC4c8JiLYXBrd
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by George · project thread
Relief for a busy project's memory index, which fills its 16 KiB cap within about a day and then refuses saves. For 0.8.1. Client only: no protocol or schema change, and the daemon is untouched.
What changes
index_bytesandlimit(indexalready did).merge_candidates. These are found without a model:alikelists up to three pairs of facts that share at least a third of the words in their names and descriptions;longestlists the longest index lines past the line limit;unreadlists facts no agent has read or saved in 30 days.memory_fullnames the same facts in its detail, so the agent knows where to start instead of deleting whatever comes to hand.description_too_long, which says how many bytes to cut. A fact whose line was already longer can be saved again with a line no longer than it had, so existing facts keep working.docs/SONNY.mdand FEATURES.md.What stays
The budget stays at 16 KiB. Both indexes go whole into every agent's instructions, which are capped at 60 KiB on the client and 64 KiB in the daemon, so a larger budget would leave agents unable to start (
instructions_limit). The lasting fix is a budgeted view in the prompt plus a memory search. That needs a recall eval first, so it isn't in this PR.Tests
a_new_index_line_past_the_line_limit_is_refused_and_an_old_one_may_not_growa_nearly_full_index_names_facts_to_merge_and_a_full_one_names_them_tooa_refused_cleanup_says_when_what_it_kept_overfills_the_indexwas reworked: it used 3,500-byte descriptions to fill the index with four facts, and it now fills it with lines near the cap.cargo test -p agent-clientpasses and clippy is clean.exec::tests::a_script_ends_on_its_time_its_memory_or_its_turnfailed once under a parallel run and passes alone, both on this branch and on main; it's unrelated.Generated by Claude Code