Hi! I merged your PR to add Av3Emulator v3.4.13 to vpm-listing-curated yesterday. Thank you!
I noticed in the diff that you're reflecting on public fields in the new VRCRaycast component. It looks like this is to support users with older SDK versions, so this code will quietly return if the raycast types don't exist. Nice; but it's tripping my reflection alarm! If we make field changes in the future, your code would break.
I'd like to recommend that you remove the reflection, and instead use the 'Version Defines' mechanism of assembly definition files: on lyuma.av3emulator.asmdef, you should be able to add a custom compiler flag for VRC_RAYCAST like so:
and then access VRCRaycast's public fields directly, within a #if VRC_RAYCAST define.
Let me know if I've missed anything that invalidates this request. Thank you!
Hi! I merged your PR to add Av3Emulator v3.4.13 to vpm-listing-curated yesterday. Thank you!
I noticed in the diff that you're reflecting on public fields in the new VRCRaycast component. It looks like this is to support users with older SDK versions, so this code will quietly return if the raycast types don't exist. Nice; but it's tripping my reflection alarm! If we make field changes in the future, your code would break.
I'd like to recommend that you remove the reflection, and instead use the 'Version Defines' mechanism of assembly definition files: on
lyuma.av3emulator.asmdef, you should be able to add a custom compiler flag for VRC_RAYCAST like so:and then access VRCRaycast's public fields directly, within a
#if VRC_RAYCASTdefine.Let me know if I've missed anything that invalidates this request. Thank you!