Skip to content

Design for StrCtx that takes delimiter or maximum size #117

Description

@m4b

See initial discussion in #108 (comment)

We may want to change behavior of DelimiterUntil, but probably more likely we'd add a ctx with this behavior.

Here are the only uses of DelimiterUntil in goblin:

src/pe/symbol.rs
207:                .pread_with(offset, ctx::StrCtx::DelimiterUntil(0, 8))
466:            .pread_with(offset, ctx::StrCtx::DelimiterUntil(0, length))

Either way it's a breaking change since we don't have non-exhaustive on StrCtx.

cc @kkent030315

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions