feat(gpui): support Linux glass backgrounds on Wayland and X11 - #4
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linux previously ignored the window background APIs used by Ghostex’s glass settings. Implement them for Wayland and X11, with a WGPU backdrop pass matching the macOS background sources and eight live styles.
Validation: Linux crate checks, full Ghostex release build and bundle, and WGSL validation passed on the original integration checkout. The user confirmed the result works in Hyprland (Ghostex uses XWayland for CEF). Native Wayland and a standalone Xorg session have not been visually tested. Compositor blur strength remains compositor-controlled.
Companion Ghostex PR: maddada/Ghostex#165 exposes the settings and pins this revision. After rebasing onto current upstream,
cargo check -p gpui_linux -p gpui_wgpualso passed. No automated tests were added, per the repository instructions.Note
Add Linux glass backgrounds for
gpuion Wayland and X11Adds a new glass backdrop system to the Linux
gpuistack. A GPU renderer in glass.rs draws image, video, or procedural live backgrounds (aurora, nebula, bokeh, and others) into a 320x200 canvas and composites it into the target surface before the main scene pass in wgpu_renderer.rs.PlatformWindowbackground setters toGlassstate and request redraws while a background needs another frame; Wayland now prefers the standard background-effect protocol over the KDE blur manager.WgpuRendererCoreframe rendering switches the main pass fromcleartoloadwhen glass is configured; check wgpu_renderer.rs. Video playback also spawns FFmpeg child processes that are killed on drop; check video.rs.Macroscope summarized 8bd6c6e.