fix(windows): restore cursor on mouse exit and window deactivation - #5
Merged
maddada merged 1 commit intoSep 29, 2026
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
maddada
added a commit
to gvastethecreator/Ghostex
that referenced
this pull request
Sep 29, 2026
maddada/zed#5 is merged; its PR commit also carried a stray README line, removed on ghostex, so the pin moves to the ghostex head.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the pointer was hidden while typing, mouse exit and window deactivation marked it visible without restoring the Win32 cursor. The next mouse move then skipped restoration, leaving the pointer invisible over Ghostex.
Call the existing
restore_cursor_after_hidehelper from both paths so the visibility flag and native cursor change together. This targets theghostexbranch and preserves its existing cursor and popup behavior.Validation:
ghostexbranch.The README review notice is required by the dependency's local agent instructions.
Note
Fix Windows cursor restoration on mouse exit and window deactivation
Replaces direct cursor-visibility flag updates with the existing
restore_cursor_after_hidehelper in events.rs. BothWindowsWindowInner.handle_mouse_leave_msgandWindowsWindowInner.handle_activate_msgnow restore the native Win32 cursor when the shared state says it was hidden, instead of only flipping the visibility flag.Macroscope summarized 0e95a78.