Repository navigation
fix: reject circular CSS module imports - #176
Open
wozhenbang2004 wants to merge 3 commits into
Open
wozhenbang2004 wants to merge 3 commits into
wozhenbang2004 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #175.
Circular
composesand@valueimports now reject with the dependency chain, for exampleCircular dependency: .../b.css -> .../a.css -> .../b.css, instead of repeatedly loading the same files. Each branch carries its own ancestry, so parallel branches can still share dependencies.Added regressions for both import syntaxes, self-imports, nested cycles, diamond dependencies and concurrent entry points. The four circular cases time out on master at the five-second limit; all six cases pass with the fix.
make lint compile USE_DOCKER=0,npm exec -- jest --runInBand(105 tests, 35 snapshots), and formatting checks pass on Node 24.22.3 / Linux. Also checked the built package with real files for resolver aliases, reuse after a failed render, cached imports and longer acyclic chains. Windows was not run.