Repository navigation
Hardcode codex in the README template's badge links - #176
Merged
Merged
Conversation
The badges in doc/README.md used ${project.artifactId}, which is
codex-parent at the root pom. The publish profile renders README.md
from this template, so a local -P publish build rewrote the badges to
point at a codex-parent repo that doesn't exist. Divinity and Fabled
are single-module, so the expression is correct there.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Secz6aiBJ7U8im8tnYhyLA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow-up fix to #166.
doc/README.mdis the template that thepublishprofile renders intoREADME.md. #166 wrote its new badges with${project.artifactId}, which iscodex-parentat the root pom. So any-P publishbuild, the release build included, rendered badges pointing at amagemonkeystudio/codex-parentrepo that doesn't exist. CI no longer commits the rendered README, so the README on GitHub is still correct. But a local-P publishbuild would leave a broken README behind to commit.This hardcodes
codexin the four badge lines. The rest of the template is unchanged; the dependency snippet already usescodex. Divinity and Fabled are single-module, so${project.artifactId}is right there.Testing: after
mvn -N process-resources -P publish -Drevision=1.2.0,README.mdis unchanged.Generated by Claude Code