Repository navigation
Run javadoc for pre-26 NMS modules on the JDK 21 toolchain - #178
Merged
Merged
Conversation
JDK 22+ javadoc fails on the type annotations in the older Spigot jars the same way javac did (missing datafixerupper classes), which broke the 1.2.0 release at attach-javadocs for codex-nms-v1_20_1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Secz6aiBJ7U8im8tnYhyLA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Build #20 got past the compile fix from #177, then failed at
maven-javadoc-plugin:jar (attach-javadocs)forcodex-nms-v1_20_1. On JDK 25, javadoc reads type annotations from the Spigot jar just like javac does, and hits the same error:This PR gives
maven-javadoc-pluginthe samejdkToolchain(${nms.jdk}) that the compiler already has incodex-nms/pom.xml. Pre-26 modules now run javadoc on JDK 21, and 26.x modules still use 25.Tested locally: I reproduced CI's classpath by excluding datafixerupper from the v1_20_1 Spigot dependency and building with
-P publishon JDK 25 with toolchains for 21 and 25.Toolchain in maven-javadoc-plugin: JDK[…java-21…], the javadoc jar is built, and the build succeeds.The same "Cannot attach type annotations" line still shows up during lombok's delombok step. It's non-fatal and was already there before this change.
Generated by Claude Code