Repository navigation
Build codex-nms-v1_21_11 against Spigot 1.21.11-R0.2-SNAPSHOT - #179
Merged
Merged
Conversation
Spigot moved 1.21.11 to R0.2, so BuildTools --rev 1.21.11 no longer installs R0.1. Maven then took R0.1 from mvn.lumine.io, whose Spigot pom has no dependencies, and the module failed to compile without com.mojang.serialization (Release Build #21). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Secz6aiBJ7U8im8tnYhyLA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Build #21 failed in
codex-nms-v1_21_11withpackage com.mojang.serialization does not exist.Cause: Spigot moved 1.21.11 to
R0.2-SNAPSHOT, soBuildTools --rev 1.21.11now installs R0.2. The module still asked for R0.1, so Maven fetched R0.1 frommvn.lumine.ioinstead. Lumine's Spigot poms list no dependencies, which left DataFixerUpper and Mojang's serialization library off the classpath.This PR bumps
spigotandspigot-apiin the v1_21_11 module to1.21.11-R0.2-SNAPSHOT. The Minecraft version is the same, so the obfuscated NMS names don't change.1.20.1 had the same problem for a different reason: it was missing from the BuildTools list in
.github. That fix is a separate patch to the shared workflow.Tested locally: I built
1.21.11and1.20.1with BuildTools, then ranmvn -o -P publish packageon the v1_21_11 and v1_20_1 modules. The build ran on JDK 25 with toolchains for 21 and 25, and-okept anything from coming from Lumine. Both modules compile and build their javadoc and sources jars.Generated by Claude Code