Repository navigation
Show the build name as the plugin version - #180
Merged
Merged
Conversation
plugin.yml, paper-plugin.yml and bungee.yml now show ${display.version}, which
defaults to the project version. CI sets it to the build's name, X.Y.Z-dev.N for
a dev build or X.Y.Z for a release, so users can say exactly which build they run.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Secz6aiBJ7U8im8tnYhyLA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of giving every dev build a name users can share,
X.Y.Z-dev.N. The shared workflow (.githubpatch 0011) numbers each dev build, tags it and publishes it as a GitHub pre-release, and passes the name to Maven as-Ddisplay.version.Changes
plugin.yml,paper-plugin.yml,bungee.yml:version: ${display.version}.pom.xml:display.versiondefaults to${project.version}, so local builds are unchanged, and CI sets it to1.2.1-dev.1or1.2.1. The Maven version staysX.Y.Z-SNAPSHOT, so Fabled and Divinity keep following the latest dev build.With this,
/version Codexon a server shows e.g.1.2.1-dev.3. That's also the tag and GitHub pre-release the build can be downloaded from. Fabled's and Divinity's minimum-Codex check now orders these correctly (magemonkeystudio/fabled#1894, magemonkeystudio/divinity#356).Testing
mvn package -DskipNms(JDK 25):plugin.yml/paper-plugin.ymlbungee.yml1.2.0-SNAPSHOT1.2.0-SNAPSHOT-Drevision=1.2.1 -Dchangelist=-SNAPSHOT -Ddisplay.version=1.2.1-dev.11.2.1-dev.11.2.1-dev.1-Drevision=1.2.1 -Dchangelist=1.2.11.2.1Generated by Claude Code