Repository navigation
Conversation
- Bump Codex to 1.2.0-R0.7-SNAPSHOT, the first build that recognises 26.3 (as Version.V26_R2), and raise MIN_CORE_VERSION to match. - Add a V26_R2 packet handler. Without it, PacketManager finds no class for V26_R2 and silently skips packet handling on 26.3. - 26.3 turned ClientboundLevelParticlesPacket into a record, so getParticle()/getCount() became particle()/count() and the final count field can no longer be set reflectively. V26_R2 reads the record accessors and swaps in a copy of the packet with the capped count via EnginePacketEvent#setPacket. V26_R1 now exposes these steps as overridable hooks; its 26.1/26.2 behaviour is unchanged. The other reflected packets and members (equipment, attributes, entity data, ServerLevel/MinecraftServer lookups) are unchanged between the vanilla 26.2 and 26.3 server jars. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AGio1LrsF6DKSa3La6Hh7o
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for Minecraft 26.3.
codex.version→1.2.0-R0.7-SNAPSHOT, the first build that recognises 26.3 (asVersion.V26_R2).MIN_CORE_VERSIONis raised to match.V26_R2packet handler:PacketManagerlooks up the handler class byVersion.CURRENT.name(). Without aV26_R2class, packet handling would be silently skipped on 26.3.ClientboundLevelParticlesPacketto a Java record. The accessors were renamed (getParticle()/getCount()→particle()/count()), and reflective writes to record fields throwIllegalAccessException. So the damage-indicator particle cap (max 20) would have failed and printed a stack trace on every hit.V26_R2reads the record accessors, builds a copy of the packet with the capped count through its canonical constructor, and swaps it in withEnginePacketEvent#setPacket. Codex sends whatever packet is on the event after dispatch.V26_R1hooks:V26_R1now exposesgetParticle/getParticleCount/setParticleCountas overridable hooks. Behaviour on 26.1/26.2 is unchanged.All other reflected members are identical between the vanilla 26.2 and 26.3 server jars, so they needed no changes. Those are the equipment/attribute/entity-data packets,
ServerLevel#getEntity(int),MinecraftServer#getAllLevels,EquipmentSlot#byName,Registry#getKey,Identifier#getPathandBuiltInRegistries.PARTICLE_TYPE.Testing
mvn -U testpasses: 43 tests, 0 failures, 2 skipped.javapagainst the vanilla 26.3 server jar.Known issue (not addressed here)
On all of 26.1–26.3,
V26_R1#manageEntityNameswrites toSynchedEntityData$DataValue.value, andDataValueis also a record. So the entity-names visibility mode likely has no effect on 26.x and logs a stack trace on every entity-data packet. That should be fixed in a follow-up.🤖 Generated with Claude Code
https://claude.ai/code/session_01AGio1LrsF6DKSa3La6Hh7o
Generated by Claude Code