Repository navigation
Add support for Minecraft 26.3 - #116
Merged
Merged
Conversation
Adds a v26_3 NMS module based on v26_2 and routes 26.3 servers to it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M29zjaS6FKDHdSRMvxwdYn
Contributor
Author
|
Build Artifacts fails because There's nothing to fix in this PR. Deploy the NMS modules (built with JDK 25+) to repo.travja.dev, then re-run the workflow. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nms/v26_3module. It is a copy ofnms/v26_2with the package renamed, built againstorg.spigotmc:spigot/spigot-api26.3-R0.1-SNAPSHOT.nms/pom.xml, the rootpom.xml(dependencyManagement) andcore/pom.xml.NMSVersionnow maps bukkit version26.3tov26_3, which becomes the "26.3 – X" entry. The startup message now reads "1.8 to 26.3".NMSVersionStringParserTest.Verification
nms/v26_3compiles against it with no source changes. The 26.x jars are Java 25 class files, so this module has to be built with JDK 25+.defineIdorder through the class hierarchy. None of theDataWatcherKeyindices or serializers changed:ENTITY_STATUS0 (BYTE)CUSTOM_NAME2 (OPTIONAL_COMPONENT)CUSTOM_NAME_VISIBILITY3 (BOOLEAN)ITEM_STACK8 (ITEM_STACK)ARMOR_STAND_STATUS15 (BYTE)SLIME_SIZE18 (INT): Mob 15, AgeableMob 16–17, AbstractCubeMobID_SIZE18ServerLevel#getNextEntityId()has the same bytecode as 26.2 and still uses the static, sharedENTITY_COUNTER.FriendlyByteBufconstructor thatEntityMountNMSPacketcalls by reflection still exists and reads the same fields.ClientboundRemoveEntitiesPacketis now a record, but it keeps itsint...constructor and its VarInt-list wire format.NMSVersionStringParserTestcases. They ran throughpom-dev.xmlwith the locally installed 26.3 module.Not verified
pom.xmlbuild and the plugin jar:repo.codemc.iowas unreachable from the build environment.Note on CI
PR CI builds
pom-dev.xml, which downloads the NMS modules prebuilt from repo.travja.dev atnms.version3.0.15-SNAPSHOT.illusion-nms-v26_3isn't published there yet, so CI will fail with a dependency-resolution error until the NMS modules are deployed (using JDK 25+).🤖 Generated with Claude Code
https://claude.ai/code/session_017qUTaedHzgfkoHoWe3eC4B
Generated by Claude Code