Repository navigation
Conversation
Previously, subshells would inherit the same random number sequence as the parent shell, which could lead to unexpected behavior in scripts that rely on randomness. This change ensures that each subshell generates a different sequence of random numbers. The sequence is still deterministic if the user seeds $RANDOM to a specific value. When subshells are forked after seeding to the same value, subshells in the same position in the fork tree will yield the same sequence, but other subshells will yield different sequences. This is achieved by saving the given seed in the `seed_candidate` variable, which is then updated deterministically when a subshell is forked. Fixes #256
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, subshells would inherit the same random number sequence as the parent shell, which could lead to unexpected behavior in scripts that rely on randomness. This change ensures that each subshell generates a different sequence of random numbers.
The sequence is still deterministic if the user seeds
$RANDOMto a specific value. When subshells are forked after seeding to the same value, subshells in the same position in the fork tree will yield the same sequence, but other subshells will yield different sequences. This is achieved by saving the given seed in theseed_candidatevariable, which is then updated deterministically when a subshell is forked.Fixes #256