[snawaz]

What changed

Removes Magic Program's global validator keypair and startup initialization. Accept and set-stage transactions now use Engine's borrowed signer; builtin authority checks continue using Engine's thread-local pubkey. Test helpers initialize only a pubkey.

Partially addresses #1535.

Remaining work for #1535

The leader still copies the authority keypair into the callback service, committor, and Chainlink, and clones Engine's signer for fee-vault funding. The committor execution context still owns a Keypair. Those paths must use Engine's signer without owning copies before Engine is the sole keypair owner.

The stack's receipt coverage uses RedSuite PR #302.

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: magicblock-labs/magicblock-validator
• Branch: fix/replayable-settlement-receipts
• File: .coderabbit.yaml
• Commit: 00f2791
• Layers: Repository YAML
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: 9180218e-6a6e-4b86-be40-6e20c53969a7

Commits

Reviewing files that changed from the base of the PR and between 00f2791 and a441660.

Files selected for processing: 11

• bins/validator/src/leader.rs
• committor/src/execution/test_utils.rs
• committor/src/shared/outbox/outbox_client.rs
• programs/magic-program/Cargo.toml
• programs/magic-program/src/intent_bundles/process_execute_callback.rs
• programs/magic-program/src/intent_bundles/schedule/process_schedule_commit_tests.rs
• programs/magic-program/src/outbox_intent/process_close_outbox_intent.rs
• programs/magic-program/src/schedule_task/process_schedule_task.rs
• programs/magic-program/src/test_utils/mod.rs
• programs/magic-program/src/utils/instruction_utils.rs
• programs/magic-program/src/validator.rs

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Tip

🎯 Customize your risk assessments

Guide how CodeRabbit assesses merge risk and security architecture risk. Highlight sensitive changes and explain your security boundaries using Merge Risk Instructions and Security Risk Instructions in your review settings. Security architecture risk assessments require the Advanced plan or above.

✅ Automatic approvals, with your rules

Let CodeRabbit approve pull requests once required threads are resolved, pre-merge checks pass, and your risk limits are met. Enable Automatic approvals in review settings, with overrides for teams or file paths.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn