Skip to content

fix: align scenarios with validator dev behavior - #278

Merged
bmuddha merged 4 commits into
mainfrom
fix/validator-dev-expectations
Oct 29, 2026
Merged

bmuddha merged 4 commits into
mainfrom
fix/validator-dev-expectations

Conversation

@bmuddha

@bmuddha bmuddha commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

What changed

Upgrades the direct DLP API dependency to 4.0.1 and uses its 1,000,000-lamport commit-fee constant. This replaces the stale constant re-exported by the SDK without duplicating pricing locally. The existing Magic ATA overlay scenario now waits for delegation to replace an empty overlay without an explicit close.

The ephemeral-account security scenario now expects resize and close to reject imported, unfunded Magic accounts. They have no ephemeral rent deposit, so local writability must not grant access to the shared rent vault. The existing funded-account lifecycle remains the control.

Simplifies the lifecycle branches and keeps projection/restoration checks with their operations. Payer delegation and callback accounting also share their repeated setup and calculations.

Supports validator #1856, including its fix for validator #1855. Related to #276.

Reviewer notes

This covers empty-overlay takeover; funded balances, approvals, frozen accounts, and transfer/revoke overlap remain in #276. Live execution is unverified here because the local macOS environment lacks a compatible Yellowstone plugin.

@bmuddha bmuddha added bug Something isn't working rust Pull requests that update rust code labels Oct 28, 2026
@bmuddha bmuddha self-assigned this Oct 28, 2026
@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@bmuddha bmuddha changed the title fix: align redshift with validator dev behavior fix: align scenarios with validator dev behavior Oct 28, 2026
@bmuddha
bmuddha marked this pull request as ready for review October 29, 2026 08:55
@bmuddha
bmuddha merged commit 1c8113f into main Oct 29, 2026
2 checks passed
@bmuddha
bmuddha deleted the fix/validator-dev-expectations branch October 29, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working rust Pull requests that update rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant