Skip to content

test(committor): cover mixed legacy and dlp v2 settlement - #299

Merged
snawaz merged 1 commit into
test/dlp-v2-buffered-settlement-restoredfrom
test/dlp-mixed-settlement-restored
Nov 5, 2026
Merged

snawaz merged 1 commit into
test/dlp-v2-buffered-settlement-restoredfrom
test/dlp-mixed-settlement-restored

Conversation

@snawaz

@snawaz snawaz commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

What changed

Adds one legacy cell and one v2 cell to the same commit intent, then undelegates both in a second intent. It checks exact data, commit IDs, ownership return, and the DLP instruction versions used on the base chain.

Closes #283

Reviewer notes

Built on #298. Uses the existing legacy fixture and the v2 setup from #297. Live qualification remains pending the Linux run with validator #1860.

Previously merged as #287 and reverted in #296.

@snawaz
snawaz added this pull request to stack #300 November 2, 2026 13:53
@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between cfe7d8e and bbe6083.

Files selected for processing: 4

  • README.md
  • redshift/src/scenarios/committor/dlp_mixed_settlement.rs
  • redshift/src/scenarios/committor/mod.rs
  • redshift/src/scenarios/mod.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@snawaz
snawaz force-pushed the test/dlp-mixed-settlement-restored branch from a033e13 to bbe6083 Compare November 4, 2026 15:53
@snawaz
snawaz removed this pull request from stack #300 November 4, 2026 15:54
@snawaz
snawaz added this pull request to stack #308 November 4, 2026 15:55
@snawaz
snawaz marked this pull request as ready for review November 5, 2026 12:02
@snawaz
snawaz merged commit 1651925 into dlp-v2 Nov 5, 2026
2 of 3 checks passed
@snawaz
snawaz deleted the test/dlp-mixed-settlement-restored branch November 5, 2026 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mixed legacy and DLP v2 settlement coverage

1 participant