docs: drop face_mappings from all-faces face swap generate examples - #175
Merged
Merged
Conversation
face_mappings only applies to individual-faces mode. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
generateexamples for face swap photo and face swap video setface_swap_mode: "all-faces"but also passface_mappings.face_mappingsis only used inindividual-facesmode, so here it's noise and makes it look required. This PR removes it from the sync and async examples in the custom docs block.These examples feed the code samples on magichour.ai/api through web-app's sync script. The generated
.createexamples and params table come from the OpenAPI spec, which magichourhq/web-app#16040 fixes. They update on the next SDK regeneration.Checked each snippet with
mypy --strictagainst the package types.🤖 Generated with Claude Code