Require generated clients to forward the user JWT - #171
Merged
Merged
Conversation
A hand-rolled resource client that only sets MAJOR_JWT_TOKEN is rejected on resource calls. App code must use the generated client. cron.json is not a scheduler.
rishikesh-major
requested review from
jasonzbao and
josegironn
as code owners
September 24, 2026 21:35
The using-connectors skill is for app code. Drop the sentence that treated MAJOR_JWT_TOKEN-only clients as a valid script pattern.
jasonzbao
approved these changes
Sep 24, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
App coders have been constructing
PostgresResourceClientby hand with onlyMAJOR_JWT_TOKEN, including for webhooks and cron routes. A resource call to go-api withoutx-major-user-jwtwill be rejected.cron.jsonis no longer registered.What
app-builder: use the generated client. A webhook and a workflowapp_callalready have the user JWT. Do not addcron.json.using-connectors: examples that pass onlymajorJwtTokenare for scripts outside a request, not app code.