Repository navigation
fix: make bunx available in sandbox and auto-start gpg-agent - #32
Merged
Merged
Conversation
malaporte
marked this pull request as ready for review
April 13, 2026 06:52
|
🎉 This PR is included in version 0.20.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small fixes to improve the default sandbox experience: symlink
bunxalongsidebunin the default image, and automatically startgpg-agenton the host when it isn't running at sandbox start time.Changes
src/cli/default-dockerfile.ts: addln -sf /root/.bun/bin/bunx /usr/local/bin/bunxsobunxis available in the sandbox by default (mirrors the existingbunsymlink)src/cli/sandbox.ts: inresolveGpgSocketInfo, whengpgconfreturns a socket path but the file doesn't exist yet, rungpg-agent --daemononce and wait up to 500 ms for the socket to appear — eliminating the spurious warning for users whose agent simply wasn't running yetTesting
bun run typecheck— cleanbun run test— 139/139 passingbun run build— all platform binaries compile successfullyReviewer Notes
gpg-agent --daemonis idempotent; if the agent is already running it exits with a non-zero code which is silently ignored.Atomics.waitin 50 ms slices to stay synchronous — in practice the socket appears within one iteration.gpg-agentgenuinely cannot be started or the socket never materialises after the timeout.