Repository navigation
Delete types and contract protocols nothing references - #1364
Conversation
The architecture review found these with no use outside their own files; each was re-checked against Sources and Tests on master: DragToAuthorizeProofOfConcept, MockConfigRepairService, ProcessKiller, EventTapController (and its TapError), SimpleLogViewer, SafetyAlertPresenter, KindaVimDetector, WizardPreflightView, MockSystemData, and the LifecycleControlling, PermissionChecking, Logging and EventTapping contracts with the types only they used. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Review of the diff (1129 deletions, no additions): I found no correctness, security or performance problems in the removed code. Most of it looks like dead scaffolding. That includes the unused contract protocols, I could only see the diff, so I couldn't check for remaining references. Please confirm that nothing still uses these symbols, including in
A green No other actionable findings. |
Summary
Removes 1,129 lines that nothing references. Each type was re-checked with
git grep -wagainstSourcesandTestson master:DragToAuthorizeProofOfConcept,MockConfigRepairService,ProcessKiller,EventTapController(and itsTapError),SimpleLogViewer,SafetyAlertPresenter,KindaVimDetector,WizardPreflightView,MockSystemDataCore/ContractsprotocolsLifecycleControlling,PermissionChecking,LoggingandEventTapping, along with the types that only they used (LogLevel,LoggingConfiguration,LogDestination,SystemPermissionType,PermissionStatus,PermissionConfidence,SystemPermissionSnapshot,TapHandle).PermissionSetandPermissionSubjecthits elsewhere are different types (PermissionOracle.PermissionSet, and the wizard module's ownPermissionSubject).From the architecture review's next tier ("12+ types with no references", "Unused contract protocols"). The dead
SystemFacadestart/stop/restart paths andkanata.entitlementsare left for the privileged-stack deletion, because they belong to the retired stack and its signing contract.Testing
swift build: passes with no errors.Review gate: remote review gate selected (the local review run timed out with no output).
🤖 Generated with Claude Code