Repository navigation
Conversation
SystemStatusIndicator ran a 60 Hz Timer.publish for as long as the view existed, waking the main thread even after the gear stopped. The angle is now computed from time inside TimelineView(.animation(paused:)), which pauses once the gear has decelerated to a stop. Same speed (180 deg/s) and the same 0.6 s quadratic ease-out. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Review: no actionable findings. I checked the new time-derived rotation in
Minor, non-blocking: there is no automated coverage for the phase math. If it's cheap, pull 🤖 Generated with Claude Code |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SystemStatusIndicatordrove its spinning gear withTimer.publish(every: 1/60)that never stopped, so the main thread woke 60 times a second for as long as the indicator existed, long after validation finished.The angle is now a function of time inside
TimelineView(.animation(paused: animationPhase == .stopped)):(1 - t)^2speed curve over 0.6 s.task(id:)moves the phase to stopped when the slowdown endsUnused state (
isAnimating,rotationSpeedDegPerSec) andimport Combineare removed.From the architecture review's next tier ("60 Hz timer never stops").
Testing
swift buildpasses;swiftformat --lint(0.61.1) is clean.Review gate: remote review gate selected (the local review run timed out with no output).
🤖 Generated with Claude Code