Skip to content

binary host mirror override does not work for module_names with multiple dashes #896

Description

@sdgrimm

The binary host mirror environment variable does not work for packages with binary.module_name values containing more than one dash because it does not use replaceAll here: https://github.com/mapbox/node-pre-gyp/blob/master/lib/util/versioning.js#L315. I encountered this trying to use the binary host mirror override with https://github.com/confluentinc/confluent-kafka-javascript/blob/master/package.json#L19.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions