Repository navigation
remove eval() - #646
Open
k-yle wants to merge 1 commit into
Open
remove eval()#646k-yle wants to merge 1 commit into
eval()#646k-yle wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
eval(ornew Function) is considered dangerous and discouraged, even if this paticular usage is safe.By using eval, this library prevents consumers from enabling stricter security settings like a Content Security Policy or Trusted Types.
Have you read the Contributing Guidelines?
yes
Contribution
Replaced
eval/new Functionwith procedural code.Instead of constructing the filter using code like
return "!(" + expression + ")";, we now use actual JS code likereturn (x) => !f(x);Test Plan
all the existing unit tests for
FilterCreator.test.tsstill pass