Skip to content

fix(grade): softer hand Grade under the Shadow Reach floor, and a quiet softest-Grade warning - #1692

Merged
marcinz606 merged 2 commits into
mainfrom
mz/flat
Nov 17, 2026
Merged

marcinz606 merged 2 commits into
mainfrom
mz/flat

Conversation

@marcinz606

@marcinz606 marcinz606 commented Nov 17, 2026 •

Copy link
Copy Markdown
Owner

What

Two changes to the Grade slider on the Tone card.

1. A softer hand Grade prints under the Shadow Reach floor

With Auto Grade on, Shadow Reach raises the slope until the darkest detail prints dark. The floor also held every softer Grade that the user set. The slider stopped there and warned that the negative was flat, while the same frame printed softer with Auto Grade off.

The floor now holds the meter's grade and a harder one. A softer grade R prints the floored meter slope times 115 / R, clamped to slope_min. The slider is continuous at the meter's value, and the harder side is unchanged.

  • auto_base_slope holds the rule, so the CPU, the GPU and the chart follow it.
  • print_stored_value has the matching inverse, so the slider shows what prints.
  • Frames with a stored softer Grade under an active floor render softer. THUMBNAIL_RENDER_VERSION goes to 42.
  • docs/PIPELINE.md states the rule.

2. The softest-Grade warning is on the value

The warning was an amber line with an icon under the slider. It moved the rows below it each time it came and went.

The Grade value now turns amber, and the warning text is the tooltip of the value. After change 1, the warning shows only when the slope is at slope_min, so its text is true.

  • CompactSlider.set_advisory(text): amber value and a tooltip on it. An empty string clears both.
  • The longer tooltip string of the old line is retired from the 7 catalogs. No new strings.

Checks

  • New tests in tests/test_auto_sliders.py: a softer Grade prints under the floor, a harder Grade keeps the floor, the slope is continuous with no floor, and the stored value inverts the shown value under the floor.
  • pytest -k "grade or exposure or thumbnail or golden or curve or auto or relocation or characteristic or parity or roll": 2648 passed, 4 skipped. tests/test_thumbnail_fingerprint.py passes after its record was refreshed for version 42.
  • ruff check, ruff format --check on the changed files, and make type: clean.
  • A drag simulation on the flat test frame: the slider moves past the old stop and stops at slope_min, where the warning shows.
  • The real Tone sidebar, rendered offscreen: the value is amber and the widget under the pointer resolves to the warning tooltip.
  • The full make all was not run.

Not tested

  • The tooltip popup on a real display.
  • A real frame with a large gap between the Shadow Reach floor and slope_min. The test frame has a small gap.

A flat negative reaches the slope floor before the Grade slider reaches
R180. The warning for this was an amber line under the slider, which
moved the rows below it each time it came and went.

The Grade value now turns amber, and the warning is its tooltip. The row
geometry does not change. CompactSlider.set_advisory holds the look, and
the second tooltip string is retired from the catalogs.
With Auto Grade on, Shadow Reach raises the slope until the darkest
detail prints dark. The floor also held every softer Grade the user set,
so the slider stopped and warned that the negative was flat, while the
same frame printed softer with Auto Grade off.

The floor now holds the meter's grade and a harder one. A softer grade
scales the floored meter slope by its ISO R ratio, so the slider moves
on from the floor and stops only at slope_min. The warning then shows
only for a negative that is flat.

Frames with a stored softer Grade under an active floor render softer,
so THUMBNAIL_RENDER_VERSION goes to 42.
@marcinz606 marcinz606 changed the title fix(tone): show the softest Grade warning on the value, not on a line fix(grade): softer hand Grade under the Shadow Reach floor, and a quiet softest-Grade warning Nov 17, 2026
@marcinz606
marcinz606 merged commit 130913e into main Nov 17, 2026
4 of 5 checks passed
@marcinz606
marcinz606 deleted the mz/flat branch November 17, 2026 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant