Repository navigation
fix(grade): softer hand Grade under the Shadow Reach floor, and a quiet softest-Grade warning - #1692
Merged
Merged
Conversation
A flat negative reaches the slope floor before the Grade slider reaches R180. The warning for this was an amber line under the slider, which moved the rows below it each time it came and went. The Grade value now turns amber, and the warning is its tooltip. The row geometry does not change. CompactSlider.set_advisory holds the look, and the second tooltip string is retired from the catalogs.
With Auto Grade on, Shadow Reach raises the slope until the darkest detail prints dark. The floor also held every softer Grade the user set, so the slider stopped and warned that the negative was flat, while the same frame printed softer with Auto Grade off. The floor now holds the meter's grade and a harder one. A softer grade scales the floored meter slope by its ISO R ratio, so the slider moves on from the floor and stops only at slope_min. The warning then shows only for a negative that is flat. Frames with a stored softer Grade under an active floor render softer, so THUMBNAIL_RENDER_VERSION goes to 42.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two changes to the Grade slider on the Tone card.
1. A softer hand Grade prints under the Shadow Reach floor
With Auto Grade on, Shadow Reach raises the slope until the darkest detail prints dark. The floor also held every softer Grade that the user set. The slider stopped there and warned that the negative was flat, while the same frame printed softer with Auto Grade off.
The floor now holds the meter's grade and a harder one. A softer grade
Rprints the floored meter slope times115 / R, clamped toslope_min. The slider is continuous at the meter's value, and the harder side is unchanged.auto_base_slopeholds the rule, so the CPU, the GPU and the chart follow it.print_stored_valuehas the matching inverse, so the slider shows what prints.THUMBNAIL_RENDER_VERSIONgoes to 42.docs/PIPELINE.mdstates the rule.2. The softest-Grade warning is on the value
The warning was an amber line with an icon under the slider. It moved the rows below it each time it came and went.
The Grade value now turns amber, and the warning text is the tooltip of the value. After change 1, the warning shows only when the slope is at
slope_min, so its text is true.CompactSlider.set_advisory(text): amber value and a tooltip on it. An empty string clears both.Checks
tests/test_auto_sliders.py: a softer Grade prints under the floor, a harder Grade keeps the floor, the slope is continuous with no floor, and the stored value inverts the shown value under the floor.pytest -k "grade or exposure or thumbnail or golden or curve or auto or relocation or characteristic or parity or roll": 2648 passed, 4 skipped.tests/test_thumbnail_fingerprint.pypasses after its record was refreshed for version 42.ruff check,ruff format --checkon the changed files, andmake type: clean.slope_min, where the warning shows.make allwas not run.Not tested
slope_min. The test frame has a small gap.