Skip to content

fix(process): Color settings on a B&W roll shouldn't carry to a color roll - #1693

Draft
kurtwindisch wants to merge 6 commits into
marcinz606:mainfrom
kurtwindisch:fix/bw-chroma-carry
Draft

kurtwindisch wants to merge 6 commits into
marcinz606:mainfrom
kurtwindisch:fix/bw-chroma-carry

Conversation

@kurtwindisch

@kurtwindisch kurtwindisch commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Note

This is based on a previously suspected cause for #1642, which would be a user error if accurate. The fix here addresses both a possible user error and the behavior that makes it hard for the user to recognize the error (carrying color settings from a B&W frame that hides them from the panels).

Summary

Related to #1642. After B&W rolls, new color rolls rendered gray. A switch between B&W and Color changed the tone but not the gray, and only Reset Settings brought the color back.

Chroma (lab.saturation) is a carried setting by default. A B&W frame hides the Chroma slider and leaves it out of the edited count, so a Chroma of 0 on a B&W roll is invisible. It still carried to the next fresh file with Film Mode B&W, and a switch to Color kept the 0.

Changes

  • features/process/models.py: leaving black and white (Film Mode, or B&W off on a Slide) sets a Chroma of exactly 0 back to 1 (chroma_for_mono, beside cast_removal_for_mode). with_process_mode and with_slide_bw apply it, so every mode change gets it, autodetect on load included. Any other value stays, and a pasted Chroma still wins.
  • desktop/session.py: a black-and-white frame does not carry its hidden color controls (Chroma, Skin Protection, Chroma Denoise) to a fresh file. BW_UNUSED_LAB_FIELDS is now public, so one constant says what B&W hides and what it does not carry.
  • desktop/sticky.py: a one-time migration sets a carried Chroma of 0 back to 1. A user already hit by the bug can hold Color with Chroma 0 in the carried settings, where no mode switch runs. Saved edits are left alone.
  • desktop/controller.py: a Film Mode push to the roll (the Setup card's Roll button) sets only the roll's default, so with_process_mode never runs on the other frames. The push now applies chroma_for_mono to each loaded frame that follows the roll's Film card and leaves black and white. The write is inside the Apply to Roll batch, so Undo restores it. A frame locked on Film keeps its own Chroma.
  • desktop/view/canvas/hud.py, main_window.py: the reporter's gray came from a Greyscale export profile, which Soft Proof (on by default) previews until a proof profile is chosen, and which carries to every file. The canvas strip now shows a standing amber warning while a color frame previews through a gray profile: "Gray preview from the {profile} profile. Choose another profile or turn off Proof on Screen." A message still takes the slot, and the warning comes back after it. CanvasHud.set_advisory is the one place for other standing warnings about the preview, as the owner suggested on [Bug]: Roll stuck on black and white #1642. The gray check reads the ICC header (icc_profile.is_gray_profile). The Soft Proof guide panel says so in every language.
  • THUMBNAIL_RENDER_VERSION 42 → 43: a roll's Color film default now restores Chroma on a saved B&W frame with Chroma 0.
  • Tests for each mode transition, the paste order, the carry rule, the migration and the issue's steps at config level.

No guide change: the reset is an automatic edge case.

Known trade-off

A Chroma of 0 chosen on a color frame is lost on a round trip through B&W and back to Color. The B&W frame cannot tell it from a hidden carried 0.

A Film Mode push to the roll reaches only the frames loaded in the Film Strip, as every roll push does. A member that is not loaded, such as a file on a disconnected drive, keeps its Chroma.

Merge order

No order is required. main is merged in. Open PRs that bump THUMBNAIL_RENDER_VERSION (#1584) or edit tests/thumbnail_fingerprint_defaults.json (#1431) conflict on those lines: whichever merges second takes one more than main's version and re-records the defaults (NEGPY_RECORD_THUMBNAIL_DEFAULTS=1).

Test plan

  • make all (one unrelated flaky test, test_frame_merge.py::test_finish_keeps_the_composite_of_a_stitch_that_failed, passed on rerun)
  • Headless app run: a fresh color file after a B&W frame with Chroma 0 opens B&W with Chroma 0 and renders gray. A switch to Color gives Chroma 1 and a color render.
  • Headless app run on a three-frame roll: Chroma 0 to the roll, B&W to the roll, then Color to the roll. Every frame is Color with Chroma 1 and renders in color.
  • Headless app run of the warning: a Greyscale export profile on a Color frame shows it; B&W, Soft Proof off or sRGB do not.
  • Look at the warning in the app on a real display.
  • Check the Film Strip thumbnails on a real display (widget grabs are black offscreen).
  • Ask the reporter how Chroma reached 0.

🤖 Generated with Claude Code

kurtwindisch and others added 3 commits November 17, 2026 09:39
…6#1642)

Chroma carries to a fresh file, and a black-and-white frame hides it. A
Chroma of 0 on a B&W roll then carried to the next color roll unseen, and
a switch to Color kept it, so the frame stayed gray until Reset Settings.

- Leaving black and white (Film Mode, or B&W off on a Slide) sets a Chroma
  of 0 back to 1 (chroma_for_mono). Any other value stays, and a pasted
  Chroma still wins.
- A black-and-white frame does not carry its hidden color controls
  (Chroma, Skin Protection, Chroma Denoise) to a fresh file.

Verified in the app: a fresh color file after a B&W frame with Chroma 0
opens gray, and the switch to Color gives Chroma 1 and a color render.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A user hit by the bug can hold Color with Chroma 0 in the carried
settings: autodetect switched the fresh frame to Color and the next
edit saved it. No mode switch then runs, so fresh files stay gray. A
one-time migration sets that carried 0 back to 1. Saved edits are left
alone.

A roll's Color film default now restores Chroma on a saved B&W frame
with Chroma 0, so THUMBNAIL_RENDER_VERSION moves to 39.

The guide and PIPELINE.md sentences are gone: the reset is an automatic
edge case, and PIPELINE.md leaves UI behavior to the guide.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…arcinz606#1642)

Pushing Film Mode from the Setup card sets only the roll's default, so
with_process_mode never ran on the other frames. A roll given Chroma 0,
then B&W, then Color kept Chroma 0 on every frame but the open one.

The push now applies chroma_for_mono to each loaded frame that follows
the roll's Film card and leaves black and white. The write is inside the
Apply to Roll batch, so Undo restores it. A frame locked on Film keeps
its own Chroma.

Verified in the app on a three-frame roll: after Chroma 0, B&W and Color
pushed to the roll, every frame is Color with Chroma 1 and renders in
color.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kurtwindisch kurtwindisch changed the title fix(process): a B&W roll no longer leaves color rolls gray fix(process): Color settings on a B&W roll shouldn't carry to a color roll Nov 18, 2026
kurtwindisch and others added 3 commits November 17, 2026 17:21
# Conflicts:
#	negpy/desktop/controller.py
#	negpy/services/assets/thumbnail_fingerprint.py
#	tests/thumbnail_fingerprint_defaults.json
…ay profile (marcinz606#1642)

Soft Proof is on by default and proofs through the export profile until a
proof profile is chosen. The export profile carries to every file, so a
Greyscale export set on a B&W roll made every later color roll preview
gray, with nothing on the frame's cards to explain it.

The canvas strip now holds a standing warning in its message slot, in the
amber of a warning message: "Gray preview from the {profile} profile.
Choose another profile or turn off Proof on Screen." A timed or held
message still takes the slot and the warning comes back after it.
CanvasHud.set_advisory is the one place for other standing warnings
about the preview.

The warning shows only while Soft Proof is active, the proof profile has
a gray color space (ICC header) and the frame's Film Mode is color. The
Soft Proof guide panel says so in every language.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant