Repository navigation
feat(flat): Flat Scan stays on while you edit - #1695
Open
thetalkingdrum wants to merge 3 commits into
Open
thetalkingdrum wants to merge 3 commits into
thetalkingdrum wants to merge 3 commits into
Conversation
Add reaches_flat_master(section, *fields) beside flat_master_config. It is the one source the Flat Scan view will gray its controls from. A later change that makes the flat render read a new field adds it here only. tests/test_flat_master_fields.py changes every Exposure field and every card-owned Process field, renders the flat master in C-41, B&W and E-6, and checks that the pixels move exactly when reaches_flat_master says so. A B&W slide's flat master stays color today (_process_flat collapses only a B&W negative); the test holds that as a strict xfail.
Flat Scan is now a view of the open frame that follows the edit. With it on, a plain render renders the flat master of the current edit, so an edit, undo or redo, a rotate or flip, a committed fine rotation, crop or Keystone, and a frame switch keep the view on. toggle_flat_peek and rerender_active_view make a plain render; request_render substitutes the flat config. The memo key, the thumbnail and metrics readback test the substituted override, so flat pixels are never filed as the print. A frame switch skips the render memo while Flat Scan is on, because the memo holds the frame's print. A drag renders the proxy and the release the full preview. The views that take the canvas still end it: compare, the Average peek, the Export Size view, the negative and embedded peeks, zone placement, a Linear or print launch recipe, and closing the last file. The Peek Flat Scan and Preview Flat tooltips no longer say the view shows only for a moment.
Every gate asks reaches_flat_master, so a field that later reaches the flat render enables its control with no other change. Controls gray out and never hide. - The bodies of Tone, Dodge & Burn, Lab, Alternative Processes, Toning, Retouch and Finishing gray out. Each tab with a grayed control shows one hint. - Filtration keeps Global color and Pick WB live and grays the Shadows and Highlights sliders and the ring-around. A Shadows or Highlights Pick WB ends, because the flat master ignores those fields. - Paper Response keeps the Print stock live on a color negative. Pick Better and the Auto mirror gray out. - The Roll tab grays Cast Average on the Baseline card. - Export warns when the canvas is flat and Output Intent is not Flat. - Flat Scan ends Pick Better and print-only tools and refuses them while it is on. The Clipping and Zone overlays and Zone Highlight gray out. The guide says that Flat Scan stays on while you edit and that the print-only controls gray out.
Contributor
Author
|
@marcinz606 I added this now as it was ready, but feel free to review it after your trip if you think it's too much in the new features category. It does make working with flat quite a bit more friendly. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
Flat Scan (
M) shows the flat master, the low-contrast file that Output Intent Flat exports. Since #1318, an edit or a frame switch ends it. Before #1318 the view went stale instead: after an edit the canvas painted the print, and the FLAT SCAN badge stayed lit. Ending the view fixed that, but you still cannot work on a flat master. Each white balance or crop change drops you back to the print, and you pressMagain. #1318 left the better fix for later: keep the view on, render the edit, and gray out the controls it cannot show.What this changes
reaches_flat_masterlookup decides which ones, and a test checks each field against the render.Notes
THUMBNAIL_RENDER_VERSIONandBOUNDS_VERSIONstay as they are.Open questions