Notify participant domains and push recipients_added on add-to - #34
Merged
Conversation
AddRecipients now records one msg_add_to_notify row per remote participant domain of the message -- the domains of from and every to address, excluding domains hosting one of the batch's new recipients (they learn through normal delivery) and the local domain (this database is its record) -- so fmsgd delivers the add-to message to every participant domain per SPEC §10.2, not only the new batch's. Addresses already added to the message are now rejected up front: msg_add_to is unique per (msg, addr), so re-adding silently no-opped and could leave a batch with no recipients, which fmsgd would deliver as an invalid add-to message. Re-adding an original to recipient stays allowed (SPEC §10.3 NOTE II). The websocket hub listens on the new recipients_added channel (fired by fmsgd's dd.sql when a batch is recorded, whether added locally or received from a remote host) and pushes the refreshed message to every connected participant, closing the gap where existing participants got no realtime signal that recipients were added. Requires fmsgd's updated dd.sql (msg_add_to_notify table and recipients_added trigger). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AddRecipients now records one msg_add_to_notify row per remote participant domain of the message -- the domains of from and every to address, excluding domains hosting one of the batch's new recipients (they learn through normal delivery) and the local domain (this database is its record) -- so fmsgd delivers the add-to message to every participant domain per SPEC §10.2, not only the new batch's.
Addresses already added to the message are now rejected up front: msg_add_to is unique per (msg, addr), so re-adding silently no-opped and could leave a batch with no recipients, which fmsgd would deliver as an invalid add-to message. Re-adding an original to recipient stays allowed (SPEC §10.3 NOTE II).
The websocket hub listens on the new recipients_added channel (fired by fmsgd's dd.sql when a batch is recorded, whether added locally or received from a remote host) and pushes the refreshed message to every connected participant, closing the gap where existing participants got no realtime signal that recipients were added.
Requires fmsgd's updated dd.sql (msg_add_to_notify table and recipients_added trigger).