Repository navigation
test(ingest): stop importing drizzle-orm directly - #22
Merged
Merged
Conversation
The Worker package resolved its own copy of drizzle-orm once its peer set changed, and that copy's types do not match the schema from @copper/db. The pipeline test now filters rows in memory. Claude-Session: https://claude.ai/code/session_01X2rqistoob3eewaQAJVwr3
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Dependabot's grouped update (#6) fails
typecheck: bumping@cloudflare/workers-typesgivesapps/ingestits own copy ofdrizzle-orm, whoseeqdoes not accept columns from@copper/db's copy.Scope
apps/ingest/test/pipeline.test.tsfilters rows in memory;drizzle-ormleavesapps/ingest's devDependencies.Verification
pnpm verifypasses; the pipeline test still compares every table with the independently counted totals.https://claude.ai/code/session_01X2rqistoob3eewaQAJVwr3