Repository navigation
chore(ts): name Node's type definitions explicitly - #23
Merged
Merged
Conversation
TypeScript 7 no longer loads @types packages implicitly. Declaring them in core, db and tracker works on 5.9 and lets the 7.0 update typecheck. Claude-Session: https://claude.ai/code/session_01X2rqistoob3eewaQAJVwr3
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The TypeScript 7 update (#3) fails
typecheckinpackages/core: TypeScript 7 no longer loads@typespackages implicitly, socrypto,URL,RequestandResponseare unknown.Scope
"types": ["node"]in the tsconfig ofpackages/core,packages/dbandpackages/tracker.Verification
pnpm verifypasses on TypeScript 5.9.3 with this change, and on 7.0.2 with this change applied to the Dependabot branch (typecheck, 97 tests,next build, the Worker bundle).https://claude.ai/code/session_01X2rqistoob3eewaQAJVwr3