Repository navigation
chore(repo): close the remaining engineering-practices gaps - #7
Merged
Merged
Conversation
- Pin engines to Node 22.x so it matches .nvmrc and @types/node - Run the seed script in the migrations CI job as an entry-point smoke test - Stop the env error citing docs/SELF_HOSTING.md, which does not exist yet - Add CONTRIBUTING.md for the human process and link it from the README - Record new guardrails, the pending branch protection and the practices not adopted
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Husky with the pre-commit and pre-push hooks landed in #5. This is the rest of an audit of the repo against the engineering practices guide. Most of the guide was already in place; these are the gaps.
Scope
enginesgoes from>=22to22.x, matching.nvmrcand@types/node.migrationsCI job now runspnpm seed(SEED_DAYS=1) against its Postgres, so a script that dies on import fails in CI.apps/web/src/lib/env.tsno longer citesdocs/SELF_HOSTING.md, which does not exist yet.CONTRIBUTING.md(setup, what each hook runs, pull requests), linked from the README.docs/guardrails.md: rows for the above, a "Waiting on a person" section, and a "Not adopted" table with the reason for each declined practice and what would change it.Not in this change: branch protection on
mainis still unset. It is a repository setting. Requirelint,docs,typecheck,test,buildandmigrations, then prove it with one deliberately failing pull request.Verification
pnpm verifyon this branch, exit 0:The seed step was run locally before the rebase onto
main, against a throwaway PGlite database:Seeded 5 projects and 73 new flush units over 1 days.It has not been re-run since; themigrationsjob on this pull request is its first run against real Postgres.Both hooks ran for this change: pre-commit formatted the staged files, and pre-push ran
pnpm checkandpnpm buildbefore the push left.https://claude.ai/code/session_01SgUkaSu7ND42hgs4GvmnoQ