Skip to content

Adopt the engineering practices: CI, checks, hooks and feature layout - #1

Open
masaok wants to merge 1 commit into
mainfrom
engineering-practices
Open

masaok wants to merge 1 commit into
mainfrom
engineering-practices

Conversation

@masaok

@masaok masaok commented Oct 1, 2026

Copy link
Copy Markdown
Owner

Why

The repository had no gate, no CI and no written rules. This adopts the same engineering baseline as the private costexplorer-cloud repository, so a change is proven by one command locally and on GitHub before the engine work starts.

Scope

  • pnpm verify runs typecheck, lint, format check, repository checks, tests, build and smoke. .github/workflows/ci.yml runs the same commands as six jobs.
  • The starting page moves to src/features/home. src/app/page.tsx only re-exports it. Lint enforces the layer boundaries.
  • Prettier with husky and lint-staged, Node 24 pinned in .nvmrc, an install preflight and Dependabot.
  • docs/ gains the feature map, the guardrails table, the audit and the agent eval scenarios.

Not in this pull request: the project rules in AGENTS.md and .claude/skills/, which follow in a stacked pull request.

Verification

VERIFIED. pnpm verify on Node 24.21.0, run on this commit with the instruction files stashed.

All matched files use Prettier code style!
PASS feature-map (2 surfaces in code, 2 rows)
PASS docs-links (29 relative links in 9 markdown files)
PASS versions (Node 24, 2 workflow files)
ℹ tests 12
ℹ pass 12
ℹ fail 0
✓ Compiled successfully in 296ms
PASS GET / 200, text "To get started, edit the"
PASS GET /favicon.ico 200, type "image/x-icon"
2 surfaces requested, 0 failures

https://claude.ai/code/session_01WTtRZcdke1yYdYUAanaf7V

Add the pnpm verify gate with typecheck, lint, format, repository
checks, tests, build and smoke, and the CI workflow that runs the same
commands. Move the starting page into src/features/home behind a thin
route file, enforce the layer boundaries in lint, pin Node 24 in .nvmrc
and document the rules in docs/.

Claude-Session: https://claude.ai/code/session_01WTtRZcdke1yYdYUAanaf7V
Copilot AI balanced review requested due to automatic review settings October 1, 2026 23:57
@vercel

vercel Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
costexplorer Ready Ready Preview Oct 1, 2026 11:57pm UTC

Request Review

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

This branch was successfully deployed

1 active deployment
Preview — 1fc74b3a Deployed Oct 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants