Skip to content

Android: offer Open links in a post's actions - #30

Merged
masonasons merged 2 commits into
masonasons:mainfrom
serrebidev:android-open-links
Oct 20, 2026
Merged

masonasons merged 2 commits into
masonasons:mainfrom
serrebidev:android-open-links

Conversation

@serrebidev

Copy link
Copy Markdown
Contributor

Problem

On Android, turning on Open links in Settings > post actions never adds it to a post. Swiping through a post's actions with TalkBack, and the long-press menu, have no Open links item.

StatusRow builds its actions from the configured order. It has no case for the links key, so the key falls through to else -> null // a catalog action Android doesn't wire yet. Android also never handled the core's url_picker event, which open_post_links sends when a post has more than one link.

Fix

  • StatusRow: links now gives an Open links action that sends open_post_links, as iOS does (MainViewController.swift, case "links"). Like iOS, it appears on every post. The core already says "No links in this post." when there are none, opens a single link directly, and sends url_picker for several.
  • CoreViewModel handles url_picker with a linkPicker state. HomeScreen shows it as a "Which link?" chooser, the same pattern as the media picker. A choice opens through the existing openLink Custom Tab path.
  • The comment listing unwired keys no longer names links.
  • docs/changelog.txt: one line under 0.6.1.

No core change.

Testing

  • Built assembleDebug (0.6.1-debug) and installed it beside the release build on a Galaxy Tab S10+ (Android 16) running a TalkBack-based screen reader.
  • The reporter, a blind user, confirmed on that tablet that Open links now appears in a post's actions and works.
  • browser, post_info, followers, following, follow_hashtag and pin_post are still unwired on Android. They can be turned on in Settings but never appear. This PR leaves them alone.

🤖 Generated with Claude Code

serrebidev and others added 2 commits October 20, 2026 01:16
Settings lists "Open links" as a post action, but StatusRow had no case
for the "links" key, so turning it on did nothing. Wire it to
open_post_links, as iOS does, and handle the core's url_picker event
with a chooser like the media picker.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@masonasons
masonasons merged commit 2f2717b into masonasons:main Oct 20, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants