Repository navigation
Android: offer Open links in a post's actions - #30
Merged
Merged
Conversation
Settings lists "Open links" as a post action, but StatusRow had no case for the "links" key, so turning it on did nothing. Wire it to open_post_links, as iOS does, and handle the core's url_picker event with a chooser like the media picker. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Android, turning on Open links in Settings > post actions never adds it to a post. Swiping through a post's actions with TalkBack, and the long-press menu, have no Open links item.
StatusRowbuilds its actions from the configured order. It has no case for thelinkskey, so the key falls through toelse -> null // a catalog action Android doesn't wire yet. Android also never handled the core'surl_pickerevent, whichopen_post_linkssends when a post has more than one link.Fix
StatusRow:linksnow gives an Open links action that sendsopen_post_links, as iOS does (MainViewController.swift,case "links"). Like iOS, it appears on every post. The core already says "No links in this post." when there are none, opens a single link directly, and sendsurl_pickerfor several.CoreViewModelhandlesurl_pickerwith alinkPickerstate.HomeScreenshows it as a "Which link?" chooser, the same pattern as the media picker. A choice opens through the existingopenLinkCustom Tab path.links.docs/changelog.txt: one line under 0.6.1.No core change.
Testing
assembleDebug(0.6.1-debug) and installed it beside the release build on a Galaxy Tab S10+ (Android 16) running a TalkBack-based screen reader.browser,post_info,followers,following,follow_hashtagandpin_postare still unwired on Android. They can be turned on in Settings but never appear. This PR leaves them alone.🤖 Generated with Claude Code