powere_pos lemmas - #969
Merged
Merged
Conversation
affeldt-aist
force-pushed
the
exp_20230706
branch
from
July 6, 2023 06:04
5ea42e7 to
a46d7fd
Compare
affeldt-aist
added
TODO: MC2 port
Member
Author
|
Most of the contents of this PR has already been reviewed by @zstone1 and @CohenCyril (now an author) so maybe this can be merged quickly? CI errors are because of the lack of adequate images or mathcomp failures due the transitional state from mathcomp 1 to mathcomp 2. |
proux01
approved these changes
Jul 6, 2023
proux01
left a comment
proux01
left a comment
Collaborator
There was a problem hiding this comment.
A few minor comments. I'll merge once addressed.
- refactoring by Cyril Co-authored-by: Alessandro Bruni <alessandro.bruni@gmail.com> Co-authored-by: Cyril Cohen <cohen@crans.org>
proux01
removed
the
TODO: MC2 port
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.classicalsuffixes fromImport'spower_postopowRMotivation for this change
this is the part of PR #942 about power_pos,
isolated here for the sake of clarity
Things done/to do
CHANGELOG_UNRELEASED.mdCompatibility with MathComp 2.0
TODO: HB portto make sure someone ports this PR tothe
hierarchy-builderbranch or I already opened an issue or PR (please cross reference).Automatic note to reviewers
Read this Checklist and put a milestone if possible.