Print changed file names to stdout; add --null and --name-delimiter by Copilot · Pull Request #724 · mathiasrw/rexreplace

Copilot · 2026-10-12T16:31:54Z

Breaking change: in-place edits now print changed paths on stdout (one per line), like grep -l / gofmt -l / prettier --write. stderr is only for errors, --verbose, and --debug.

Behavior

Names still suppressed by --quiet / --quiet-total
No names when using --output, --output-match, or piped data (nothing written in place)
Async finish order is unchanged; --void-async keeps list order

New flags

--null / -0 — NUL after each name (safe for spaces/newlines in paths)
--name-delimiter <string> — separator between names, no trailing delimiter; escapes and €/§ match the replacement
The two flags conflict

Implementation

printChangedName() in src/output.ts writes names to stdout; info/chat stay on stderr
doReplacement() in src/engine.ts calls it after successful writes
CLI wiring + delimiter unescaping in src/cli.ts
JS, fuzzy, and CLI tests updated for stdout names and the new flags

rexreplace foo bar '**/*.md' | xargs git add
rexreplace foo bar '**/*.md' --null | xargs -0 git add
rexreplace foo bar '*.md' --name-delimiter ', '
# a.md, b.md

Fixes Print the names of affected files #703

Co-authored-by: mathiasrw <1063454+mathiasrw@users.noreply.github.com>

mathiasrw · 2026-10-12T17:19:51Z

@copilot please see updated descirtion of original issue about the absolutelpath printing

Co-authored-by: mathiasrw <1063454+mathiasrw@users.noreply.github.com>

Copilot · 2026-10-12T17:22:06Z

@copilot please see updated descirtion of original issue about the absolutelpath printing

Implemented --absolute-path / -a in e0f5b8c (or the latest push commit). Default still prints the path as given; with the flag each changed name is the full path from / (same form as file in --replacement-js).

mathiasrw · 2026-10-12T17:29:18Z

 		}
 	}

+	if (undefined !== config.nameDelimiter && null !== config.nameDelimiter) {


There seems to be a misunderstanding. If --null then use \n. If config.nameDelimiter treat § €, else use \n

Fixed in 8150175. nameDelimiter is now set once up front: \0 with --null, the treated custom value with --name-delimiter, otherwise \n.

mathiasrw · 2026-10-12T17:29:53Z

+			if (!config.voidSection) {
+				delimiter = delimiter.replace(/§/g, '\\');
+			}
+			delimiter = unescapeString(delimiter);
+			if (!config.voidEuro) {
+				delimiter = delimiter.replace(/€/g, '$');
+			}
+			if (!config.voidSection) {
+				delimiter = delimiter.replace(/§/g, '\\');
+			}


Why are we doing voidSecion twice?

Fixed in 8150175. § is applied once before unescape (same as the replacement); €/§ run again only in the engine via replacePlaceholders.

mathiasrw · 2026-10-12T17:30:15Z

+				delimiter = delimiter.replace(/§/g, '\\');
+			}
+			config.nameDelimiter = delimiter;
+		} catch (e) {


Why are we putting this in a try catch?

Kept only around unescapeString, same as the replacement — invalid sequences like \x4 need a clean error instead of a stack trace. Fixed in 8150175.

mathiasrw · 2026-10-12T17:30:55Z

 const now = new Date();

-import {outputConfig, step, debug, chat, info, error, die} from './output.ts';
+import {outputConfig, step, debug, chat, printChangedName, error, die} from './output.ts';


Please dont rename. Its info keep that.

Fixed in 8150175. Restored info; removed printChangedName.

mathiasrw · 2026-10-12T17:32:11Z

 		return fs.promises
 			.writeFile(_file_rr, result, _config_rr.encoding)
-			.then(() => info(_file_rr), error);
+			.then(() => printChangedName(nameToPrint), error);


Its an info.

Fixed in 8150175. Engine calls info(name) again after a successful write.

mathiasrw · 2026-10-12T17:32:35Z

+// Tracks whether a changed-file name has already been written, so --name-delimiter
+// can separate names without a trailing delimiter after the last one.
+let namePrinted = false;
+


No no no. We make sure we dont process the same file multiple times.

Fixed in 8150175. Dropped namePrinted. Overlapping globs are deduped in getFilePaths, and info skips a path already reported.

Co-authored-by: mathiasrw <1063454+mathiasrw@users.noreply.github.com>

mathiasrw · 2026-10-14T00:55:53Z

Closing. The quality of this is not where it has to be.

It is far too bulky for what it does. The delimiter is worked out in four places and drags five extra bits of state around, for something that is a few lines.
--name-delimiter with --halt loses the names of the files that were already changed, because all names are held back to the very end.
--absolute-path puts the working directory in front of a path that is already absolute. That is the bug from A file given with an absolute path is not changed #726 made once more.
The review comment about not handling the same file twice was answered with two new Sets instead of none. fast-glob already gives each file once.
The readme is not updated with the new flags.

#703 will be done again from scratch on current main, as a small change.

Initial plan

0e16342

Copilot AI assigned Copilot and mathiasrw Oct 12, 2026

Copilot started work on behalf of mathiasrw October 12, 2026 16:32

View session

Copilot AI linked an issue Oct 12, 2026 that may be closed by this pull request

Print the names of affected files #703

Open

Copilot AI and others added 2 commits October 12, 2026 16:40

Print changed file names to stdout; add --null and --name-delimiter

b8a7b49

Co-authored-by: mathiasrw <1063454+mathiasrw@users.noreply.github.com>

Align --name-delimiter § handling with replacement after unescape

bd04fb5

Co-authored-by: mathiasrw <1063454+mathiasrw@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Print names of changed files to stdout~~ Print changed file names to stdout; add --null and --name-delimiter Oct 12, 2026

Copilot finished work on behalf of mathiasrw October 12, 2026 16:47

Copilot AI requested a review from mathiasrw October 12, 2026 16:47

Copilot started work on behalf of mathiasrw October 12, 2026 17:20

View session

Add --absolute-path (-a) for full paths of changed files

565b92f

Co-authored-by: mathiasrw <1063454+mathiasrw@users.noreply.github.com>

Copilot finished work on behalf of mathiasrw October 12, 2026 17:23

mathiasrw requested changes Oct 12, 2026

View reviewed changes

Copilot started work on behalf of mathiasrw October 12, 2026 17:33

View session

Address review: keep info(), simplify name delimiter, dedupe files

8150175

Co-authored-by: mathiasrw <1063454+mathiasrw@users.noreply.github.com>

Copilot finished work on behalf of mathiasrw October 12, 2026 17:40

Copilot AI requested a review from mathiasrw October 12, 2026 17:40

mathiasrw closed this Oct 14, 2026

Conversation

Copilot AI commented Oct 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Behavior

New flags

Implementation

Uh oh!

mathiasrw commented Oct 12, 2026

Uh oh!

Copilot AI commented Oct 12, 2026

Uh oh!

mathiasrw Oct 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 12, 2026

Choose a reason for hiding this comment

Uh oh!

mathiasrw Oct 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 12, 2026

Choose a reason for hiding this comment

Uh oh!

mathiasrw Oct 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 12, 2026

Choose a reason for hiding this comment

Uh oh!

mathiasrw Oct 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 12, 2026

Choose a reason for hiding this comment

Uh oh!

mathiasrw Oct 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 12, 2026

Choose a reason for hiding this comment

Uh oh!

mathiasrw Oct 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 12, 2026

Choose a reason for hiding this comment

Uh oh!

mathiasrw commented Oct 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Oct 12, 2026 •

edited

Loading